RFR: 8290464: Optimize ResourceArea zapping on ResourceMark release [v2]

Aleksey Shipilev shade at openjdk.org
Tue Jul 19 14:56:59 UTC 2022


On Tue, 19 Jul 2022 13:15:45 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments: simplify
>
> src/hotspot/share/memory/resourceArea.hpp line 126:
> 
>> 124:     }
>> 125: 
>> 126:     if (have_more_chunks || (_hwm != state._hwm)) {
> 
> If we started another chunk, _hwm must have been changed. So I would shorten this to `if  (_hwm != state._hwm)`. You can add an assert that the hwm should be different if we have follow up chunks.

All right, done so.

-------------

PR: https://git.openjdk.org/jdk/pull/9543


More information about the hotspot-runtime-dev mailing list