Integrated: 8290324: Move atomic operations outside of os_xxx.hpp
Ioi Lam
iklam at openjdk.org
Thu Jul 21 05:16:03 UTC 2022
On Thu, 14 Jul 2022 21:38:58 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> The os_xxx.hpp files inject extra methods/fields that are specific to atomic operations into the `os` class. However, the injected methods/fields are used only by a specific os/cpu combination. Therefore, they should not be inside the `os` class, which should contain only APIs that are used across platforms.
>
> - For ports where the `atomic_copy64()` function is used in a single file, I moved it as an inline function in that file
> - Otherwise it's moved to `atomic_<os>_<cpu>.hpp`
> - The linux/arm port is a little more involved, but the new code should be a little cleaner than the old code.
This pull request has now been integrated.
Changeset: 2c73a1f3
Author: Ioi Lam <iklam at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/2c73a1f39dc635d10edbb312a8f9a9852f95a7d0
Stats: 311 lines in 15 files changed: 123 ins; 135 del; 53 mod
8290324: Move atomic operations outside of os_xxx.hpp
Reviewed-by: dholmes, kbarrett
-------------
PR: https://git.openjdk.org/jdk/pull/9501
More information about the hotspot-runtime-dev
mailing list