RFR: 8290731: Clean up CDS handling of LambdaForm Species classes

[Calvin Cheung]

On Wed, 20 Jul 2022 20:53:17 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Please see the JBS issue for the reasons for this small clean up.
> 
> The main change is in `LambdaFormInvokers::regenerate_holder_classes()` -- do not regenerate the Species_XXX classes. However, mark them as "generated" to be compatible with JVMTI.
> 
> I renamed `Klass::is_regenerated()` to `Klass::is_generated_shared_class()` for clarity.
> 
> I also updated the test case to be clear what it's trying to do -- Species_IL should be loaded from base archive and Species_JL should be loaded from the dynamic archive.

Looks good. One small nit.

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/CDSLambdaInvoker.java line 32:

> 30:     public static void main(String args[]) throws Throwable {
> 31:         // The following calls trigger the generation of new Species classes
> 32:         // that are not included in the base archive (or the default modules image.

Extra open parenthesis?

-------------

Marked as reviewed by ccheung (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9577