RFR: 8290370: Convert SymbolPropertyTable to Resource Hashtable
Zhengyu Gu
zgu at openjdk.org
Thu Jul 21 20:22:31 UTC 2022
On Thu, 14 Jul 2022 15:13:15 GMT, Justin Gu <duke at openjdk.org> wrote:
> Converting the invoke_method_table into two tables, invoke_method_instrinsic_table and invoke_method_type_table
Changes requested by zgu (Reviewer).
src/hotspot/share/classfile/systemDictionary.cpp line 92:
> 90: #endif
> 91:
> 92: class InvokeMethodKey : public StackObj {
It is odd to declare as `StackObj`, should be value object instead.
src/hotspot/share/runtime/mutexLocker.cpp line 45:
> 43: Mutex* CompiledMethod_lock = NULL;
> 44: Monitor* SystemDictionary_lock = NULL;
> 45: Mutex* InvokeMethodTable_lock = NULL;
Please align the value.
src/hotspot/share/runtime/mutexLocker.cpp line 265:
> 263:
> 264: def(JmethodIdCreation_lock , PaddedMutex , nosafepoint-2); // used for creating jmethodIDs.
> 265: def(InvokeMethodTable_lock , PaddedMutex , safepoint);
Align the parameters
src/hotspot/share/runtime/mutexLocker.cpp line 324:
> 322: def(ContinuationRelativize_lock , PaddedMonitor, nosafepoint-3);
> 323:
> 324:
Extra empty line
-------------
PR: https://git.openjdk.org/jdk/pull/9495
More information about the hotspot-runtime-dev
mailing list