RFR: 8291067: macOS should use O_CLOEXEC instead of FD_CLOEXEC

[David Holmes]

On Sun, 31 Jul 2022 21:52:01 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Thank you for the review Dan!
>> 
>> I thought about it, but I decided that keeping the code in sync between linux and macOS was the priority. Eventually we might want to have a single impl shared between linux and mac I thought.
>> 
>> I ran Mach5 hs-tier1...5 for the testing.
>
> Sorry but copying a comment from os_linux to os_bsd really doesn't make sense. We've been cleaning up these "mis-ports" ever since the macOS port was done, so please don't add new occurrences.

I see now it is just not comments but also the code. Again sorry but if the Linux workarounds are for Linux then they don't belong in the BSD code. That just confuses anyone who looks at this code later. If there were eventually an os_posix shared version of this then it wouldn't include Linux specific workarounds.

-------------

PR: https://git.openjdk.org/jdk/pull/9663