RFR: JDK-8291558: unify print_jni_name_prefix_on and print_jni_name_suffix_on on posix platforms
David Holmes
dholmes at openjdk.org
Sun Jul 31 22:01:55 UTC 2022
On Fri, 29 Jul 2022 14:24:13 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> print_jni_name_prefix_on and print_jni_name_suffix_on can be unified on the OpenJDK posix platforms.
Looks good. So IIUC only 32-bit Windows needs these prefixes and suffixes.
Thanks.
src/hotspot/os/posix/os_posix.cpp line 605:
> 603:
> 604: void os::print_jni_name_prefix_on(outputStream* st, int args_size) {
> 605: // no prefix required, not even "_"
You could drop the "not even '_'" as there is no context to explain why we might have considered there is a need for it.
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9686
More information about the hotspot-runtime-dev
mailing list