RFR: 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete

Ioi Lam iklam at openjdk.java.net
Thu Jun 2 19:38:13 UTC 2022


On Thu, 2 Jun 2022 18:30:38 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please review this hotspot fix follow-up of JDK-8287107. The test which exercised this code was already added with  JDK-8287107. I've now added an assert ensuring that we don't set the cgroup path multiple times. The fix is essentially the same as on the JDK side, skip setting the cgroup path when the hierarchy is non-zero which is equivalent to the empty string match that was done in the Java code.
> 
> Testing:
> - [x] `test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java` with fastdebug on x86_64. Asserts before the code fix, passes after.
> - [ ] GHA - still running.

LGTM!

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/9001


More information about the hotspot-runtime-dev mailing list