RFR: 8280454: G1: ClassLoaderData verification keeps CLDs live that causes problems with VerifyDuringGC during Remark [v4]

[Thomas Schatzl]

> Hi all,
> 
>   can I have reviews for this change that makes a few CLDG iterations no-keepalive during GC pauses?
> 
> This fixes a bug where the `VerifyDuringGC` verification otherwise kept alive all classes, effectively disabling class unloading during (g1) concurrent mark.
> 
> Afaict this verification code is only every called during GC pauses, so the change should be fine.
> 
> As for the change itself, I tried to avoid cluttering the code with `ClassLoaderDataGraphIterator<>` by using typedefs - unfortunately only C++ 17 allows omitting the `<>` if all template parameters are defaulted.
> 
> There is also a new test case for just this.
> 
> Testing: tier1-5
> 
> Thanks,
>   Thomas

Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:

  coleenp, stefank reviews

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8949/files
  - new: https://git.openjdk.java.net/jdk/pull/8949/files/7f16efea..59911eac

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8949&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8949&range=02-03

  Stats: 8 lines in 3 files changed: 5 ins; 1 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8949.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8949/head:pull/8949

PR: https://git.openjdk.java.net/jdk/pull/8949