RFR: 8287764: runtime/cds/serviceability/ReplaceCriticalClasses failed on localized Windows

Ioi Lam iklam at openjdk.java.net
Fri Jun 3 21:27:35 UTC 2022


On Fri, 3 Jun 2022 06:58:24 GMT, KIRIYAMA Takuya <duke at openjdk.java.net> wrote:

> The ReplaceCriticalClasses verifies CDS behavior when replacing the Readable interface as an example of a class that is read after JVMTI_PHASE_PRIMORDIAL.
> However, the order in which classes are loaded is affected by the language of the test environment, so the timing at which the Readable interface is loaded also changes on Windows with multibyte characters.
> Therefore, the Readable interface is not suitable for this test and should be removed.

Looks good to me. I think this PR qualifies as a trivial change so only 1 reviewer is needed.

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/9009


More information about the hotspot-runtime-dev mailing list