RFR: 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete [v2]

Severin Gehwolf sgehwolf at openjdk.java.net
Tue Jun 7 08:49:58 UTC 2022


> Please review this hotspot fix follow-up of JDK-8287107. The test which exercised this code was already added with  JDK-8287107. I've now added an assert ensuring that we don't set the cgroup path multiple times. The fix is essentially the same as on the JDK side, skip setting the cgroup path when the hierarchy is non-zero which is equivalent to the empty string match that was done in the Java code.
> 
> Testing:
> - [x] `test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java` with fastdebug on x86_64. Asserts before the code fix, passes after.
> - [ ] GHA - still running.

Severin Gehwolf has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete
  
  Add a comment to re-trigger GHA tests.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/9001/files
  - new: https://git.openjdk.java.net/jdk/pull/9001/files/5c4cdc27..535f37b9

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=9001&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=9001&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/9001.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/9001/head:pull/9001

PR: https://git.openjdk.java.net/jdk/pull/9001


More information about the hotspot-runtime-dev mailing list