RFR: JDK-8287011: Improve container information [v3]
Matthias Baesken
mbaesken at openjdk.java.net
Tue Jun 7 13:15:08 UTC 2022
On Fri, 3 Jun 2022 15:20:23 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>>
>> handle new cgroupv1 and v2 values in TestMisc
>
> src/hotspot/os/linux/os_linux.cpp line 2271:
>
>> 2269: // the kmem (kernel memory) values are only available in cgroupv1
>> 2270: if (p_ct != NULL && strcmp(p_ct, "cgroupv1") == 0) {
>> 2271: print_container_helper(st, OSContainer::kernel_memory_usage_in_bytes(), "kernel_memory_usage_in_bytes");
>
> We wouldn't need the extra version checking gymnastics if we'd call an `OSContainer::print_version_specific_info(st);` here instead.
sounds like a good idea, but with the kmem stuff deprecated (Kernel commit adding the deprecation:
https://github.com/torvalds/linux/commit/0158115f702b ) we should maybe wait first for a reply from Thomas why he is still interested in it.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8991
More information about the hotspot-runtime-dev
mailing list