RFR: 8287854: Dangling reference in ClassVerifier::verify_class

David Holmes dholmes at openjdk.java.net
Wed Jun 8 13:44:19 UTC 2022


On Wed, 8 Jun 2022 06:08:00 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> The change is functionally correct, but this seems like a textbook case for a RAII helper class.
>
>> The change is functionally correct, but this seems like a textbook case for a RAII helper class.
> 
> I agree with David that RAII is needed here. There's one exit path that's not covered by the existing patch:
> 
> 
> void ClassVerifier::verify_class(TRAPS) {
>    ...
>    verify_method(methodHandle(THREAD, m), CHECK_VERIFY(this));
>    ...
> }

@iklam Good catch! I withdraw my approval.

-------------

PR: https://git.openjdk.java.net/jdk/pull/9075


More information about the hotspot-runtime-dev mailing list