RFR: 8287901: Loom: Failures with -XX:+VerifyStack [v2]

Ron Pressler rpressler at openjdk.java.net
Wed Jun 8 16:30:37 UTC 2022


> Please review the following change.
> 
> Debugging information added to `frame::describe` (used by `JavaThread::print_frame_layout`) was inaccurate, but proved fatal with `VerifyStack`, which uses the same information for verification.
> 
> The location of a caller frame's return address and spilled fp, which are located in the callee, were recorded by the caller frame. In the case of the special frame `Continuation.enterSpecial`, those locations were recorded incorrectly. The fix is to record the information while describing the callee frame, rather than the caller.
> 
> Passes tier1

Ron Pressler has updated the pull request incrementally with one additional commit since the last revision:

  Fix locations for interpreted frames

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/9066/files
  - new: https://git.openjdk.java.net/jdk/pull/9066/files/55108d8a..e6f306be

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=9066&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=9066&range=00-01

  Stats: 24 lines in 2 files changed: 18 ins; 0 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk/pull/9066.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/9066/head:pull/9066

PR: https://git.openjdk.java.net/jdk/pull/9066


More information about the hotspot-runtime-dev mailing list