RFR: JDK-8288003: log events for os::dll_unload [v3]

Matthias Baesken mbaesken at openjdk.java.net
Thu Jun 9 15:35:29 UTC 2022


On Thu, 9 Jun 2022 13:34:52 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove whitespace in os_linux.hpp
>
> src/hotspot/os/posix/os_posix.cpp line 718:
> 
>> 716:   if (res_dli == 0) {
>> 717:     l_path = lmap->l_name;
>> 718:   }
> 
> Can we hide this in `os::Linux::dll_path` so that the code here would simply be:
> 
> 
> const char* l_path = LINUX_ONLY(os::Linux::dll_path(lib))
>                      NOT_LINUX("<not available>");

Hi David, thanks for the advice, done.
I also added some more quoting and added the dlerror information to the error report (see os_posix.cpp).

-------------

PR: https://git.openjdk.org/jdk/pull/9101


More information about the hotspot-runtime-dev mailing list