RFR: JDK-8288003: log events for os::dll_unload [v3]
David Holmes
dholmes at openjdk.java.net
Fri Jun 10 00:00:07 UTC 2022
On Thu, 9 Jun 2022 15:35:27 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> Currently we only log events for os::dll_load, but not for os::dll_unload, this patch adds it. On some platforms (Linux/Windows) we can use OS APIs (e.g. dlinfo on Linux) to log the path of the unloaded shared lib.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> remove whitespace in os_linux.hpp
Looks good - thanks for incorporating my requests.
One minor item below.
Thanks
src/hotspot/os/linux/os_linux.cpp line 1792:
> 1790: struct link_map *lmap;
> 1791: int res_dli = ::dlinfo(lib, RTLD_DI_LINKMAP, &lmap);
> 1792: const char* l_path = "<none>";
Should this be "not available" to match the non-Linux case?
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9101
More information about the hotspot-runtime-dev
mailing list