RFR: 8280235: Deprecated flag FlightRecorder missing from VMDeprecatedOptions test

[KIRIYAMA Takuya]

On Sat, 11 Jun 2022 13:10:18 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> I would like to fix 8280235: Deprecated flag FlightRecorder missing from VMDeprecatedOptions test. 
>> 
>> FlightRecorder option has not been tested since JDK13.
>> I think we should test it, because FlightRecorder option has not been obsolete in the latest JDK.
>> Users would be in trouble if the option suddenly disappears without notice, 
>> so it's important to confirm the deprication message.
>> 
>> Also we should add a test of ExtendedDTraceProbes option.
>> The test was disabled in 8281675, because some jdk can't specify it.
>> I modified the test to be able to verify  ExtendedDTraceProbes in either case that DTRACE_ENABLED is enabled or not.
>
>> so it's important to confirm the deprication message.
> 
> It has been confirmed, just not by a regression test. Adding this is harmless _but_ you can only test this on a JVM configured with JFR so you'd need to selectively add the FlightRecorder flag after programmatically checking whether JFR is present or not (I hope we have a WhiteBox or Platform check for that).
> 
>> Also we should add a test of ExtendedDTraceProbes option.
> 
> That might be useful in 19 but this bug is being pushed to 20 and it is incorrect for 20. At the start of every release we remove  the options present in the VMDeprecatedOptions test that are obsoleted in that release as the error message changes and so would cause the test to fail.

@dholmes-ora 
Thank you for your review.
I modified the test to check whether JFR is present or not, 
and deleted the test of ExtendedDTraceProbes option.
Could you please review the fix.

-------------

PR: https://git.openjdk.org/jdk/pull/9123