RFR: 8278053: serviceability/jvmti/vthread/ContStackDepthTest/ContStackDepthTest.java failing in loom repo with Xcomp [v2]
Ron Pressler
rpressler at openjdk.org
Fri Jun 17 16:40:12 UTC 2022
On Fri, 17 Jun 2022 16:32:47 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Looking at JDK 18 runtime code for raw_pc() (should probably change the comment since it's not only used by deoptimization anymore): I'm told pc_return_offset is zero so the 'else' clause doesn't change the caller.pc if the frame isn't deoptimized.
>> Thanks to @pchilano also for explanation.
>> Can you change the comment to:
>> s/when copying f/\nwhen copying the caller frame from the heap. The caller.pc is unchanged otherwise./
>
> it's not 'f'.
Changed to say "when copying f from the heap. The caller.pc is unchanged otherwise" because it's copying f, the callee, that's the issue, as the return address to the caller is in the callee frame.
-------------
PR: https://git.openjdk.org/jdk19/pull/12
More information about the hotspot-runtime-dev
mailing list