RFR: 8288532: additional review changes for JDK-8286830

[Patricio Chilano Mateo]

On Thu, 16 Jun 2022 21:54:56 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

> Update a couple of tests that were modified by JDK-8286830. Now the tests properly
> honor any specified time limit by splitting the time between both sub-tests.
> Also pick up a sanity check based on JDK-8288497 that I've been using in recent
> stress testing.

Hi Dan,

Some comments below.

Thanks,
Patricio

src/hotspot/share/runtime/thread.inline.hpp line 151:

> 149:   ~AsyncExceptionHandshake() {
> 150:     Thread* current = Thread::current();
> 151:     if (current->is_Java_thread()) {

Why verify if this is a JavaThread? The target is always a JavaThread, and the sender of the exception is also a JavaThread(JVM_StopThread and JvmtiEnv::StopThread). Even the handshake operation will assert if the handshaker is not a JT.

test/hotspot/jtreg/runtime/Thread/StopAtExit.java line 75:

> 73:             }
> 74:         }
> 75:         timeMax /= 2;  // Split time between the two sub-tests.

Maybe bump DEF_TIME_MAX to 60 seconds now so both subtests run the original 30 seconds? My intention was to run the same test again(same time) but with the addition of threadCreator.

test/hotspot/jtreg/runtime/Thread/SuspendAtExit.java line 81:

> 79:             }
> 80:         }
> 81:         timeMax /= 2;  // Split time between the two sub-tests.

Same thing about DEF_TIME_MAX.

-------------

PR: https://git.openjdk.org/jdk19/pull/32