RFR: 8288497: add support for JavaThread::is_oop_safe() [v3]

[David Holmes]

On Thu, 16 Jun 2022 16:10:55 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> It is a bogus comment - acquire semantics has nothing to do with seeing things more quickly.
>
> I'm pretty sure that I wrote the original comment and you were one of my
> reviewers way, way back then.
> 
> When we were trying to match up the load-acquires in the accessors with
> the in-line release-store code in JavaThread::exit(), the comment was needed
> (ignoring the part about "seeing things more quickly"). Now that we have
> load-acquires in the accessors and a release-store in the setter, i.e., no more
> in-line code in JavaThread::exit(), I no longer think we need a comment to
> coordinate.
> 
> I'm in favor of dropping all instances of this comment.

Sounds good. FTR this came in with the Thread-SMR changes which were reviewed over a period of many months with some "vigorous" discussion. :) I think by the time this particular code appeared the focus was on bigger issues.

-------------

PR: https://git.openjdk.org/jdk19/pull/20