RFR: 8288532: additional review changes for JDK-8286830 [v3]

David Holmes dholmes at openjdk.org
Mon Jun 20 01:58:56 UTC 2022


On Fri, 17 Jun 2022 21:43:50 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Update a couple of tests that were modified by JDK-8286830. Now the tests properly
>> honor any specified time limit by splitting the time between both sub-tests.
>> Also pick up a sanity check based on JDK-8288497 that I've been using in recent
>> stress testing.
>
> Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision:
> 
>   VMThread can get to check in AsyncExceptionHandshake() dtr via a bailout.

Changes seem fine. It will be nice when the oop-safety check can be handled in OopHandler::release.

Thanks,
David

test/hotspot/jtreg/runtime/Thread/StopAtExit.java line 79:

> 77:         test(timeMax);
> 78: 
> 79:         // Fire-up deamon that just creates new threads. This generates contention on

Existing typo: s/deamon/daemon/

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk19/pull/32


More information about the hotspot-runtime-dev mailing list