RFR: 8280235: Deprecated flag FlightRecorder missing from VMDeprecatedOptions test [v3]

[David Holmes]

On Wed, 22 Jun 2022 06:50:42 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote:

>> I would like to fix 8280235: Deprecated flag FlightRecorder missing from VMDeprecatedOptions test. 
>> 
>> FlightRecorder option has not been tested since JDK13.
>> I think we should test it, because FlightRecorder option has not been obsolete in the latest JDK.
>> Users would be in trouble if the option suddenly disappears without notice, 
>> so it's important to confirm the deprication message.
>> 
>> Also we should add a test of ExtendedDTraceProbes option.
>> The test was disabled in 8281675, because some jdk can't specify it.
>> I modified the test to be able to verify  ExtendedDTraceProbes in either case that DTRACE_ENABLED is enabled or not.
>
> KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8280235: Deprecated flag FlightRecorder missing from VMDeprecatedOptions test

Thanks for the update. Small style nit but otherwise good.

Thanks.

test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java line 71:

> 69:         ));
> 70:         if (wb.isJFRIncluded()) {
> 71:             deprecated.add(new String[] {"FlightRecorder",                  "false"});

No need for all the extra whitespace after the comma - just a single space please.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9123