Integrated: JDK-8271252: os::reserve_memory should not use mtOther as default NMT flag
Thomas Stuefe
stuefe at openjdk.org
Tue Jun 28 12:36:43 UTC 2022
On Sat, 25 Jun 2022 05:39:03 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> Small cleanup.
>
> We use mtOther as default NMT flag for os::reserve_memory():
>
> `static char* reserve_memory(size_t bytes, bool executable = false, MEMFLAGS flags = mtOther);`
>
> mtOther marks allocations coming from outside the VM. It is not a good default flag. Note that in the end mtOther then was ignored in os::reserve_memory() and it defaulted to mtNone anyway.
>
> This trivial patch straightens the logic and uses `mtNone` as default. Note that since mtOther was ignored before, there is no behavioral change.
This pull request has now been integrated.
Changeset: d4eeeb82
Author: Thomas Stuefe <stuefe at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/d4eeeb82cb2288973a6a247c54513f7e1c6b58f0
Stats: 6 lines in 2 files changed: 0 ins; 4 del; 2 mod
8271252: os::reserve_memory should not use mtOther as default NMT flag
Reviewed-by: zgu
-------------
PR: https://git.openjdk.org/jdk/pull/9287
More information about the hotspot-runtime-dev
mailing list