[jdk19] RFR: 8289091: move oop safety check from SharedRuntime::get_java_tid() to JavaThread::threadObj() [v2]

[David Holmes]

On Tue, 28 Jun 2022 13:50:51 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

> The reason that this particular handling of a secondary failure is important is
that a secondary failure in printing the name of the failing thread will prevent
entries for following threads from being printed in the thread list in the hs_err_pid
file.

Yes I realise that a secondary crash loses some information, but my contention is that:

a) the likelihood of crashing after detaching the GC barrier is very, very small; and
b) in such a crash it is only the crashing thread that is really of interest, not the other threads in the system

So to me trying to make secondary crash handling more robust in the current case is not worth the cost of the extra checks. If the checks were only in the crash reporting path then that would be okay, but not when they impact normal code execution.  Sorry.

-------------

PR: https://git.openjdk.org/jdk19/pull/69