RFR: JDK-8282593: JDK-8281472 breaks 32-bit builds and gtests

Thomas Stuefe stuefe at openjdk.java.net
Thu Mar 3 10:02:18 UTC 2022


Hi, may I please have reviews for this trivial fix.

JDK-8281472 added a test_largeOptions.cpp gtest. Parts of it don't build for 32-bits, parts build but don't run. 

I propose to exclude the failing parts. AFAICS they check that numerical arguments are handled correctly when going beyond INT_MAX and INT_MIN, which is not an issue on 32-bit with 32-bit ints.

Thanks, Thomas

-------------

Commit messages:
 - Exclude tests which dont make sense on 32-bit platforms

Changes: https://git.openjdk.java.net/jdk/pull/7672/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7672&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8282593
  Stats: 7 lines in 1 file changed: 1 ins; 3 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7672.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7672/head:pull/7672

PR: https://git.openjdk.java.net/jdk/pull/7672


More information about the hotspot-runtime-dev mailing list