RFR: JDK-8282593: JDK-8281472 breaks 32-bit builds and gtests
Thomas Stuefe
stuefe at openjdk.java.net
Thu Mar 3 13:28:02 UTC 2022
On Thu, 3 Mar 2022 11:47:06 GMT, Jie Fu <jiefu at openjdk.org> wrote:
>> Hi, may I please have reviews for this trivial fix.
>>
>> JDK-8281472 added a test_largeOptions.cpp gtest. Parts of it don't build for 32-bits, parts build but don't run.
>>
>> I propose to exclude the failing parts. AFAICS they check that numerical arguments are handled correctly when going beyond INT_MAX and INT_MIN, which is not an issue on 32-bit with 32-bit ints.
>>
>> Thanks, Thomas
>
> Looks good and trivial.
> Thanks for fixing it.
@DamonFool, @dholmes-ora Thanks for approving.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7672
More information about the hotspot-runtime-dev
mailing list