RFR: JDK-8282382: Report glibc malloc tunables in error reports [v2]

David Holmes dholmes at openjdk.java.net
Sat Mar 5 05:34:12 UTC 2022


On Fri, 4 Mar 2022 05:29:18 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> src/hotspot/os/linux/os_linux.cpp line 2120:
>> 
>>> 2118:   if (!printed) {
>>> 2119:     st->print("(default)");
>>> 2120:   }
>> 
>> else st->cr()? Rather than adding the cr() externally.
>
>> else st->cr()? Rather than adding the cr() externally.
> 
> The idea is to have output that can, if needed, be combined into larger single lines. At least that's what I usually do with functions that output small snippets.
> 
> But I do not have strong emotions here and can change it if you prefer.

There are arguments both ways so no strong enough feeling to make a change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7620


More information about the hotspot-runtime-dev mailing list