RFR: 8282690: runtime/CommandLine/VMDeprecatedOptions.java fails after JDK-8281181
Daniel D.Daugherty
dcubed at openjdk.java.net
Sat Mar 5 14:39:58 UTC 2022
On Sat, 5 Mar 2022 09:07:44 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Please review this small fix. The two options `UseContainerCpuShares` and `PreferContainerQuotaForCPUCount` are available only on Linux, so they are tested under `if (Platform.isLinux()) { ...}`
>>
>> Tested with tiers 1-4
>
> test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java line 66:
>
>> 64: DEPRECATED_OPTIONS = deprecated.toArray(new String[][]{});
>> 65:
>> 66: ArrayList<String[]> deprecated_linux = new ArrayList(
>
> Seems simpler to just add these to `deprecated` before line 64.
So move the `Platform.isLinux()` check up here and optionally
ArrayList.add() the needed strings? That does sound simpler.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7712
More information about the hotspot-runtime-dev
mailing list