RFR: 8282773: Refactor parsing of integer VM options [v2]

Ioi Lam iklam at openjdk.java.net
Thu Mar 10 04:49:20 UTC 2022


On Thu, 10 Mar 2022 02:17:07 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Merge branch 'master' into new-interger-argument-parser
>>  - fixed handling of errno
>>  - add #include <limits> for std::numeric_limits<T>
>>  - avoid UB in multiply_by_1k(); more clean-up
>>  - avoid UB operations in k/m/g/t muplication
>>  - refactored test cases
>>  - step3
>>  - step2
>>  - tmp1
>
> test/hotspot/gtest/runtime/test_arguments.cpp line 292:
> 
>> 290: }
>> 291: 
>> 292: #define INTEGER_TEST_TABLE(f) \
> 
> This looks extensive but it is hard to tell all the necessary boundary cases are covered. It would be clearer to see things like min_x-1 and max_x+1.

I've added the test cases you requested.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7763


More information about the hotspot-runtime-dev mailing list