RFR: 8283352: [CDS] SharedBaseAddress.java fails on x86_32 [v2]

[Ioi Lam]

On Fri, 18 Mar 2022 09:06:11 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Hi all, 
>> 
>> Three cds tests fail on x86_32 due to incorrect VM testing parameters.
>> 
>> runtime/cds/appcds/SharedBaseAddress.java
>> runtime/cds/SharedBaseAddress.java#id1
>> runtime/cds/SharedBaseAddress.java#id0
>> 
>> 
>> Here is part of the failing log.
>> 
>> [STDERR]
>> Improperly specified VM option 'SharedBaseAddress=8g'
>> Error: Could not create the Java Virtual Machine.
>> Error: A fatal exception has occurred. Program will exit.
>> 
>> 
>> [STDERR]
>> Improperly specified VM option 'SharedBaseAddress=0x800001000'
>> Error: Could not create the Java Virtual Machine.
>> Error: A fatal exception has occurred. Program will exit.
>> 
>> 
>> The fix just excludes them for 32-bit VMs.
>> 
>> Thanks.
>> Best regards,
>> Jie
>
> Jie Fu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comments

I think it would be better to do this. The code is easier to read and you can minimize the commit delta.


main() {
    test(testTable_32bit);
    if (is 64 bit vm) {
       test(testTable_64bit);
    }
}

static void test(String[] testTable) {
  // original code in main()....
}

-------------

PR: https://git.openjdk.java.net/jdk/pull/7863