RFR: 8282952: Thread::exit should be immune to Thread.stop
Patricio Chilano Mateo
pchilanomate at openjdk.java.net
Mon Mar 21 22:21:31 UTC 2022
On Mon, 21 Mar 2022 07:59:08 GMT, David Holmes <dholmes at openjdk.org> wrote:
> To allow Thread::exit to be immune from asynchronous exceptions causing corruption of state we introduce a simple async exception delivery deferral mechanism. Note that we still allow async exceptions to become the "pending async exception" so they are not lost (potentially desirable in other usecases), but we defer the delivery of that exception i.e when it is moved from being the "pending async exception" to being the "current pending exception" (which is the exception actually in the process of being propagated).
>
> Testing:
> - runtime/Thread/StopAtExit.java combined with logging and debugging hooks to show that exceptions were being deferred
> - tiers 1-3
>
> Thanks,
> David
Hi David,
Wouldn't it be easier to check some state in JavaThread::send_async_exception() and avoid delivering the ThreadDeath all together when the target is within that Java call in exit()?
I don't see anything obvious we can use so we could either add a new enum value in TerminatedTypes or add some new thread member variable.
Thanks,
Patricio
-------------
PR: https://git.openjdk.java.net/jdk/pull/7886
More information about the hotspot-runtime-dev
mailing list