RFR: 8283044: Use asynchronous handshakes to deliver asynchronous exceptions [v2]

Daniel D.Daugherty dcubed at openjdk.java.net
Thu Mar 24 21:52:56 UTC 2022


On Thu, 24 Mar 2022 16:49:28 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address Dan's comments
>
> src/hotspot/share/runtime/thread.cpp line 1664:
> 
>> 1662: 
>> 1663:   // Interrupt thread so it will wake up from a potential wait()/sleep()/park()
>> 1664:   java_lang_Thread::set_interrupted(threadObj(), true);
> 
> Please add a comment for the parameter name for that true.

I'm not sure where my head was at. That's just the "new_value" for the set operation
so you don't need a comment there. Sorry for the noise.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7930


More information about the hotspot-runtime-dev mailing list