RFR: 8283695: [AIX] Build failure due to name conflict in test_arguments.cpp

Ioi Lam iklam at openjdk.java.net
Fri Mar 25 18:28:45 UTC 2022


On Fri, 25 Mar 2022 17:26:51 GMT, Tyler Steele <duke at openjdk.java.net> wrote:

> The recent addition of a variable named 'BAD' in test_arguments.cpp clashes with a macro of the same name in 'sys/param.h' on AIX. Renaming the variable is sufficient to fix this build issue.

The changes look good to me, but the bug title and description should use test_arguments.cpp instead of test_properties.cpp :-)

test/hotspot/gtest/runtime/test_arguments.cpp line 295:

> 293:   /*input                      i32           u32           i64                      u64 */ \
> 294:   f("0",                       0,            0,            0,                       0                        ) \
> 295:   f("-0",                      0,            BAD_INT,      0,                       BAD_INT                      ) \

The close parenthesis should be aligned as well.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7962


More information about the hotspot-runtime-dev mailing list