Integrated: 8283469: Don't use memset to initialize members in FileMapInfo and fix memory leak

Zhengyu Gu zgu at openjdk.java.net
Mon Mar 28 12:31:47 UTC 2022


On Tue, 22 Mar 2022 00:05:32 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

> `FileMapInfo` uses `memset` in its constructor to initialize data member, it is generally a bad idea. It can break things badly if adds a new member with a non-trivial constructor and `memset` is not suitable.
> 
> Besides, it leaks malloc'd `_header` member.
> 
> Test:
> 
> - [x]  hotspot_cds
> - [x] tier1
> - [x] tier2
> - [x] runtime/cds/DeterministicDump.java

This pull request has now been integrated.

Changeset: d6fa8b00
Author:    Zhengyu Gu <zgu at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/d6fa8b004bcd0a2fc1015055d0177428889b4c31
Stats:     11 lines in 1 file changed: 5 ins; 3 del; 3 mod

8283469: Don't use memset to initialize members in FileMapInfo and fix memory leak

Reviewed-by: iklam, kbarrett

-------------

PR: https://git.openjdk.java.net/jdk/pull/7899


More information about the hotspot-runtime-dev mailing list