RFR: 8207025: JvmtiEnv::SetSystemProperty() does not handle OOM [v3]

David Holmes dholmes at openjdk.java.net
Tue Mar 29 05:52:49 UTC 2022


On Tue, 29 Mar 2022 05:24:59 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/hotspot/share/runtime/arguments.hpp line 113:
>> 
>>> 111:   bool writeable() const              { return _writeable; }
>>> 112: 
>>> 113:   bool readable() const {
>> 
>> Might be better/simpler to keep is_readable and change to is_writeable(), as that avoids changing other files.
>
> There's also `internal()`, which would need to be changed to `is_internal()` as well for consistency. I chose to change `is_readable()` to `readable()` so I just needed to change one name.

Okay.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7981


More information about the hotspot-runtime-dev mailing list