RFR: 8285832: runtime/Thread/TooSmallStackSize.java failed "assert(k->is_initialized()) failed: need to increase java_thread_min_stack_allowed calculation" [v2]

[Coleen Phillimore]

On Sun, 1 May 2022 11:36:51 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed 40 for StackShadowPages as it exceeds windows range.  Just check with 30.
>
> src/hotspot/share/runtime/os.cpp line 2007:
> 
>> 2005: // page size which again depends on the concrete system the VM is running
>> 2006: // on. Space for libc guard pages is not included in this size.
>> 2007: jint os::set_minimum_stack_sizes(size_t os_min_stack_allowed) {
> 
> Rather than pass in the minimum and spread that knowledge across each OS specific file, can we not just define a field in the os class and have it set appropriately (during os::init()?) - once from os_posix.cpp and once from os_windows.cpp?

Could do that, sure.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8471