RFR: 8284632: runtime/Thread/StopAtExit.java possibly leaking memory again [v2]

Robbin Ehn rehn at openjdk.java.net
Tue May 3 07:48:22 UTC 2022


On Tue, 3 May 2022 00:32:42 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Since we clear `_aeh` on L1679 below when `do_thread()` is executed, `_aeh` can
>> only be non-NULL when `~InstallAsyncExceptionHandshake()` runs if `do_thread()`
>> was never executed.
>> 
>> I can add that comment above L1674 in a separate bug fix if you wish.
>> @robehn - do you concur that a comment here would be good?
>
> It was the fact we null it and delete it that initially caused a "What the???" reaction. :) So I think I comment would be good but can wait.

Yes add a comment.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8388


More information about the hotspot-runtime-dev mailing list