RFR: 8285832: runtime/Thread/TooSmallStackSize.java failed "assert(k->is_initialized()) failed: need to increase java_thread_min_stack_allowed calculation" [v4]

[Coleen Phillimore]

On Tue, 3 May 2022 12:05:00 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> The minimum stack size check for ThreadStackSize, CompilerStackSize and VMStackSize should also be done for windows. I moved this to shared code with platform specific constants.
>> Windows platform was checking the option against the current thread's stack size, and not checking ThreadStackSize, and was setting the stack size against that.  It worked until you increase StackShadowPages, and then the calculation is wrong.
>> For Windows, the minimum thread stack size with current StackShadowPages of 9 in debug is now 92K rather than 188K.
>> The ShadowPageSize is too low for the loom repository and is on the bounds of current mainline, so will be increased when Loom is integrated.  When increased to 11 StackShadowPages, the smallest stack size is 100K.
>> Tested with tier1-4 on windows-x64-debug.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix windows

Thanks David.  I looked at the comments and only the last line refers to libc, so thought I should leave the comment as is because it's a useful comment.
Thanks Fred and Ioi for the reviews.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8471