RFR: 8286117: Remove unnecessary indirection and unused code in UL [v2]

Johan Sjölén duke at openjdk.java.net
Mon May 9 11:37:50 UTC 2022


On Mon, 9 May 2022 01:18:50 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> See my comment to Ioi for a more detailed explanation, but in short: No. The template parameters uniquely identify a specific tagset. The tagsets themselves are mutated in place, to accomodate for new outputs and altered decorations, for example.
>
> So really `_log` is just a simple alias that makes the other code easier to read IMO. So can't we keep `_log` and change the type?

How about `LogTagSet& _tagset`? There are more examples of `_tagset` members in UL, so it's consistent.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8541


More information about the hotspot-runtime-dev mailing list