RFR: 8286424: GetVersionEx is deprecated

[David Holmes]

On Mon, 9 May 2022 20:56:25 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change to explicitly disable deprecation warnings for the
> two uses of GetVersionEx in HotSpot code. This is a step toward being able to
> remove the global (to HotSpot) disable of deprecation warnings for Windows.
> (It is because of that global disable that these uses don't currently generate
> warnings.)
> 
> There are uses of this function in non-HotSpot parts of the JDK. These are not
> being changed. They all disable the warning in some fashion, as appropriate to
> that area's usage.  This change is only about HotSpot usage, and wanting to
> remove global deprecation disabling from HotSpot builds.

Hi Kim,

AFAICS both uses of this only try to determine whether we are running a server or client/workstation version - and for that the `IsWindowsServer()` API exists:

 https://docs.microsoft.com/en-us/windows/win32/api/versionhelpers/nf-versionhelpers-iswindowsserver
 
 But the fix itself is fine for silencing the deprecation warning (a deprecation that I didn't find documented ??).

Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8611