RFR: 8286424: GetVersionEx is deprecated [v2]

[David Holmes]

On Tue, 10 May 2022 21:29:31 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Please review this change to explicitly disable deprecation warnings for the
>> two uses of GetVersionEx in HotSpot code. This is a step toward being able to
>> remove the global (to HotSpot) disable of deprecation warnings for Windows.
>> (It is because of that global disable that these uses don't currently generate
>> warnings.)
>> 
>> There are uses of this function in non-HotSpot parts of the JDK. These are not
>> being changed. They all disable the warning in some fashion, as appropriate to
>> that area's usage.  This change is only about HotSpot usage, and wanting to
>> remove global deprecation disabling from HotSpot builds.
>
> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use IsWindowsServer

Looks good.

That "deprecation" is why we don't actually use `GetVersionEx` to get the version - see JDK-8059803.  I guess the existence of `IsWindowsServer` was overlooked at the time.

Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8611