RFR: 8286180: Enable construction of LogStreamImpl from LogMessageImpl [v4]

Johan Sjölén duke at openjdk.java.net
Wed May 18 13:53:54 UTC 2022


On Wed, 18 May 2022 02:13:19 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Johan Sjölén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Don't use get_ prefix and fix indentation
>
> src/hotspot/share/logging/logStream.hpp line 72:
> 
>> 70: 
>> 71:   virtual ~LogStreamImpl() {
>> 72:     if (_current_line.is_empty() == false) {
> 
> Nit: boolean functions can be used directly in expressions - so `if (!_current_line.is_empty()) {`

Nice, fixed!

-------------

PR: https://git.openjdk.java.net/jdk/pull/8748


More information about the hotspot-runtime-dev mailing list