RFR: 8286180: Enable construction of LogStreamImpl from LogMessageImpl [v5]

Johan Sjölén duke at openjdk.java.net
Mon May 23 10:24:01 UTC 2022


On Mon, 23 May 2022 06:47:37 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Johan Sjölén has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Use unary not instead of comparing to false
>>  - Sort includes
>>  - Style changes
>
> test/hotspot/gtest/logging/test_logStream.cpp line 101:
> 
>> 99:   {
>> 100:     LogStream foo(Log(gc)::info());
>> 101:     if(foo.is_enabled()) {
> 
> Style nit: space after "if" please - here and below.

Thank you, fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8748


More information about the hotspot-runtime-dev mailing list