RFR: 8287352: DockerTestUtils::execute shows incorrect elapsed time

Thomas Stuefe stuefe at openjdk.java.net
Thu May 26 09:01:41 UTC 2022


On Thu, 26 May 2022 04:55:00 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Please review this small change to improve the test reporting:
> 
> - Calculating elapsed time after child process has exited
> - Do not print `"Child process STDOUT is trimmed ..."` unless the lines are really trimmed.

Looks good.

I was confused btw by the name `trimLines` since that indicates that the lines where whitespace trimmed when in fact it just returns the first n lines from the input. Maybe rename that function? If you do, I don't need another review.

Thanks, Thomas

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8897


More information about the hotspot-runtime-dev mailing list