RFR: 8287352: DockerTestUtils::execute shows incorrect elapsed time [v2]

Ioi Lam iklam at openjdk.java.net
Fri May 27 04:34:45 UTC 2022


On Thu, 26 May 2022 08:58:13 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Renamed trimLines() -> limitLines()
>
> Looks good.
> 
> I was confused btw by the name `trimLines` since that indicates that the lines where whitespace trimmed when in fact it just returns the first n lines from the input. Maybe rename that function? If you do, I don't need another review.
> 
> Thanks, Thomas

Thanks @tstuefe and @mseledts for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8897


More information about the hotspot-runtime-dev mailing list