RFR: 8287398: Allow concurrent execution of hotspot docker tests

Aleksey Shipilev shade at openjdk.java.net
Fri May 27 07:58:35 UTC 2022


On Fri, 27 May 2022 05:36:08 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Remove the `exclusiveAccess.dirs=.` configuration (and thus the entire TEST.properties file) so that the  test/hotspot/jtreg/containers/docker/*.java tests can be executed concurrently. This reduces total execution from about 8 minuets to about 2.5 minuets on my machine.
> 
> In early days of JDK support for docker, we disabled concurrent execution as a precaution to avoid collisions in docker operations, such as building an image. Such collisions should no longer happen (each image is uniquely named).
> 
> In comparison, in tests/jdk/jdk/internal/platform/docker there are no such limitations, and the 6 docker tests there can be executed in parallel without issue.

Unfortunately, collisions still happen, see the uses of `Common.imageName`. I see at least two conflicts:
 - `TestMemoryAwareness` and `TestMemoryWithCgroupV1`
 - `TestPids` and `TestPidsLimit`

The first pair of tests nearly reliably fails on sufficiently large desktop after this patch. Please take a large machine and maybe test with `make test TEST=containers/docker JTREG="REPEAT_COUNT=50"`?

-------------

Changes requested by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8914


More information about the hotspot-runtime-dev mailing list