RFR: 8286180: Enable construction of LogStreamImpl from LogMessageImpl [v10]
Stefan Karlsson
stefank at openjdk.java.net
Mon May 30 12:19:42 UTC 2022
On Mon, 30 May 2022 08:06:52 GMT, Johan Sjölén <duke at openjdk.java.net> wrote:
>> May I please have a review of this PR which adds non-interleaving log streams to UL?
>>
>> In `LogMessageImpl` I remove templates and instead directly store a reference to `LogTagSet` and change `LogTagHandle` to be consistent (from pointer to reference) with `LogMessageImpl`.
>>
>> Adding a non-interleaving log stream enables UL to replace two patterns found in HotSpot:
>>
>> 1. `ttyLocker` + `(x)tty`
>> Instead of taking the global tty lock in order to ensure non-interleaving logs we can now make a `NonInterleavingLogstream` and pass that around to various `print_on(outputStream*)` functions.
>>
>> 2. `stringStream` + `outputStream*`
>> In order to avoid taking the lock and being able to take arbitrary output streams a `stringStream` is created and finally printed through `print_raw(ss.as_string())`. This however requires a `ResourceMark`, which `NonInterleavingLogStream` does not require.
>>
>> Passes tier 1.
>
> Johan Sjölén has updated the pull request incrementally with two additional commits since the last revision:
>
> - Update full name
> - Review comments 2
Marked as reviewed by stefank (Reviewer).
-------------
PR: https://git.openjdk.java.net/jdk/pull/8748
More information about the hotspot-runtime-dev
mailing list