RFR: 8296125: Add a command line option to set a refresh rate of the OS cached metrics in Linux [v2]

Olga Mikhaltsova omikhaltcova at openjdk.org
Wed Nov 2 00:21:07 UTC 2022


On Tue, 1 Nov 2022 01:24:22 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Olga Mikhaltsova has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Made the option (OsCachedMetricsRefreshRate) DIAGNOSTIC
>>  - Moved oscontainer_cache_timeout() from os::Linux to OSContainer
>
> src/hotspot/os/linux/os_linux.cpp line 190:
> 
>> 188:   return NANOSECS_PER_SEC / OsCachedMetricsRefreshRate;
>> 189: }
>> 190: 
> 
> Shouldn't this be part of the `osContainer` API rather than `os::Linux`?

Thanks! I moved it from os::Linux to OSContainer.

-------------

PR: https://git.openjdk.org/jdk/pull/10918


More information about the hotspot-runtime-dev mailing list