RFR: 8296157: Rename FileMapInfo::space_at() to region_at()

[Ioi Lam]

On Tue, 1 Nov 2022 21:39:31 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> Most of the CDS code refers to a memory blocks inside a CDS file as "regions", represented by the type FileMapRegion. The method FileRegion* space_at() has been renamed to region_at() and all instances of its use have been replaced. Verified with tier 1-4 tests.

Also the functions first_core_space/last_core_space in filemap.hpp need to be renamed. Please also check filemap.cpp to see if there are any other use of "space" that refers to a FileMapRegion.

src/hotspot/share/cds/filemap.cpp line 1763:

> 1761:       int oopmap_idx = i * 2;
> 1762:       int ptrmap_idx = i * 2 + 1;
> 1763:       region_at(region_idx)->init_bitmaps(bitmaps->at(oopmap_idx),

The next line need to be aligned.

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10937