RFR: 8296125: Add a command line option to set a refresh rate of the OS cached metrics in Linux [v2]

[Thomas Stuefe]

On Wed, 2 Nov 2022 06:00:59 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Please also remove OSCONTAINER_CACHE_TIMEOUT definition from osContainer_linux.hpp.
>> 
>> Cheers, Thomas
>
>> Please also remove OSCONTAINER_CACHE_TIMEOUT definition from osContainer_linux.hpp.
>> 
> 
> Oh never mind, I see you did this already.

> > > @tstuefe if the option is DIAGNOSTIC then I don't need CSR, right?
> > 
> > 
> > Exactly :)
> 
> Avoiding a CSR request is not a reason to make a flag DIAGNOSTIC. A diagnostic flag is something you change to try and debug a problem in a product build, it is not something you always set. If some applications in some environments will need to run permanently with a different refresh rate then this should remain a full-fledged product flag.

Sorry for the smiley then, I did not want to make light of the CSR process. My original intention was not to pollute the command line space with yet another product switch. If this is to be a product switch, maybe we should investigate the root cause for the slow polling of metrics first. Maybe we can fix it. My preference would have been a debug-only switch, tbh.

-------------

PR: https://git.openjdk.org/jdk/pull/10918