RFR: 8296125: Add a command line option to set a refresh rate of the OS cached metrics in Linux [v2]
Ioi Lam
iklam at openjdk.org
Wed Nov 2 18:06:43 UTC 2022
On Wed, 2 Nov 2022 00:19:35 GMT, Olga Mikhaltsova <omikhaltcova at openjdk.org> wrote:
>> I would like to add a new command line product option:
>> -XX:OsCachedMetricsRefreshRate=value, -
>> where a value is times per second and is in the range [1; 1000000000].
>>
>> It substitutes the hardcoded timeout of 20 ms between re-readings of the OS cached metrics introduced in [JDK-8232207](https://bugs.openjdk.org/browse/JDK-8232207) and allows to set this timeout (as a refresh rate) by a user at the launch time.
>>
>> This option will be available only on Linux.
>>
>> It can be used as followed:
>> java -XX:OsCachedMetricsRefreshRate=100 MyApp
>
> Olga Mikhaltsova has updated the pull request incrementally with two additional commits since the last revision:
>
> - Made the option (OsCachedMetricsRefreshRate) DIAGNOSTIC
> - Moved oscontainer_cache_timeout() from os::Linux to OSContainer
Do you have any benchmark that shows the benefit of this switch? We don't want to add a switch, even a diagnostic one, just on a suspicion.
-------------
PR: https://git.openjdk.org/jdk/pull/10918
More information about the hotspot-runtime-dev
mailing list